Let error(null) throw null

This patch removes the weird behaviour of jv_invalid_with_msg(jv_null())
that returns jv_invalid() (i.e. empty), instead of a boxed jv_null().

The previous behaviour of  null|error  was obviously unintentional, and
allowing is jv_invalid_with_msg() to return values on which you can't
call jv_invalid_get_msg() is only error prone.
This commit is contained in:
Emanuele Torre authored and Nico Williams committed 2023-08-04 17:38:52 -05:00
1 parent 3b6e7ddd72
commit f94a9d463f
4 files changed
+4 -15

No files matched your search

-2
View File
@@ -147,8 +147,6 @@ typedef struct {
} jvp_invalid;
jv jv_invalid_with_msg(jv err) {
if (JVP_HAS_KIND(err, JV_KIND_NULL))
return JV_INVALID;
jvp_invalid* i = jv_mem_alloc(sizeof(jvp_invalid));
i->refcnt = JV_REFCNT_INIT;
i->errmsg = err;